Don't map glyphs to the Lepcha Unicode block (issue 7426) #7490
Conversation
In the PDF file in the issue, some of the glyphs end up being mapped to the Lepcha Unicode block; see https://en.wikipedia.org/wiki/Lepcha_(Unicode_block). This didn't use to matter, but after HarfBuzz updates that improved support for Lepcha fonts, in particular https://bugzilla.mozilla.org/show_bug.cgi?id=1249861, some glyphs are now moved horizontally. To avoid that, this patch adds the Lepcha block to the list of Unicode ranges that we skip when building the glyph mapping. Fixes 7426.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b3e8132534d3dcf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/de2df6c75e4cdc2/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/de2df6c75e4cdc2/output.txt Total script time: 22.67 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b3e8132534d3dcf/output.txt Total script time: 28.19 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e89c2db18ee87d6/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e89c2db18ee87d6/output.txt Total script time: 1.11 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/57e3cb8a4068528/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ea8fcad7b81121e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/ea8fcad7b81121e/output.txt Total script time: 22.99 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/57e3cb8a4068528/output.txt Total script time: 28.00 mins
|
|
I have reviewed this PR to take it out of @brendandahl's review queue as he seems quite busy at the moment. Fortunately the patch is very similar to previous patches regarding incorrect glyph mappings. I have verified the Unicode range, that it fixes the issue and that the tests pass, so this looks good to me. |
|
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3ed467867002cb9/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/3026730e01bf948/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/3026730e01bf948/output.txt Total script time: 1.24 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3ed467867002cb9/output.txt Total script time: 2.22 mins
|
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/572b51498b4fd68/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b38aaa1f02515d8/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b38aaa1f02515d8/output.txt Total script time: 22.77 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/572b51498b4fd68/output.txt Total script time: 26.62 mins
|
|
Thank you! |
In the PDF file in the issue, some of the glyphs end up being mapped to the Lepcha Unicode block; see https://en.wikipedia.org/wiki/Lepcha_(Unicode_block).
This didn't use to matter, but after HarfBuzz updates that improved support for Lepcha fonts, in particular https://bugzilla.mozilla.org/show_bug.cgi?id=1249861, some glyphs are now moved horizontally.
To avoid that, this patch adds the Lepcha block to the list of Unicode ranges that we skip when building the glyph mapping.
Fixes #7426.