Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest stable Node.js version on Travis CI and enable caching #7505

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Jul 25, 2016

This patch instructs Travis CI to:

  • Use the latest version of Node.js at all times. This makes it possible for us to catch any breakage in newer Node.js versions soon and allows us to make use of the newest functionality of Node.js. Note that the version does not need to be in quotes when it is a string, which is now the case. Previously, Travis CI had an issue with their YAML parser, causing for example 0.10 to be interpreted as 0.1, hence the need for the quotes back then (see Fails to detect Node 0.10 in .travis.yml travis-ci/travis-ci#977).
  • Cache the node_modules directory. This prevents downloading and installing the same packages for each build and thus speeds up the build quite a bit (I have seen improvements in build times of 20+ seconds). To make sure that new packages are installed when we add them to package.json, we have npm install, and to ensure that packages are updated when the version changes in package.json we have npm update. I have tested that this works as expected. Finally we move the gulp-cli installation to the install section as that it where it belongs.

Supersedes #7500.

@timvandermeij timvandermeij merged commit f4b2ad4 into mozilla:master Jul 25, 2016
@timvandermeij timvandermeij deleted the travis-ci-update branch July 25, 2016 13:29
@timvandermeij
Copy link
Contributor Author

Trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant