Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log an error when the value passed to set currentPageNumber is out of bounds (PR 7502 followup) #7529

Merged
merged 1 commit into from
Aug 7, 2016
Merged

Log an error when the value passed to set currentPageNumber is out of bounds (PR 7502 followup) #7529

merged 1 commit into from
Aug 7, 2016

Commits on Aug 7, 2016

  1. Log an error when the value passed to set currentPageNumber is out …

    …of bounds (PR 7502 followup)
    
    With PR 7502 we no longer dispatch an event when the `val` is out of bounds, so to better communicate why nothing happens this patch logs an error in that case (similar to the logging of errors when trying to set an invalid scale).
    
    The way that the default viewer is currently implemented, means that e.g. keyboard short-cuts could trigger the new error. Hence this patch also adds the necessary validation code, both to `app.js` and `pdf_link_service.js` to prevent unnecessary errors.
    Snuffleupagus committed Aug 7, 2016
    Configuration menu
    Copy the full SHA
    7706cfa View commit details
    Browse the repository at this point in the history