For embedded Type1 fonts without included ToUnicode/Encoding data, attempt to improve text selection by using the builtInEncoding to amend the toUnicode map (issue 6901, issue 7182, issue 7217, bug 917796, bug 1242142)
#7550
Conversation
Snuffleupagus
added
text-selection
4-work-in-progress
font-type1
and removed
4-work-in-progress
labels
Snuffleupagus
changed the title
ToUnicode data, attempt to improve text selection by using the builtInEncoding to amend the toUnicode mapToUnicode data, attempt to improve text selection by using the builtInEncoding to amend the toUnicode map
|
/botio test |
|
/botio test |
|
/botio-linux preview |
|
/botio test |
Snuffleupagus
changed the title
ToUnicode data, attempt to improve text selection by using the builtInEncoding to amend the toUnicode mapToUnicode/Encoding data, attempt to improve text selection by using the builtInEncoding to amend the toUnicode map
Snuffleupagus
changed the title
ToUnicode/Encoding data, attempt to improve text selection by using the builtInEncoding to amend the toUnicode mapToUnicode/Encoding data, attempt to improve text selection by using the builtInEncoding to amend the toUnicode map (issue 6901, issue 7182, issue 7217, bug 917796, bug 1242142)
|
/botio test |
…, attempt to improve text selection by using the `builtInEncoding` to amend the `toUnicode` map (issue 6901, issue 7182, issue 7217, bug 917796, bug 1242142) Note that in order to prevent any possible issues, this patch does *not* try to amend the `toUnicode` data for Type1 fonts that contain either `ToUnicode` or `Encoding` entries in the font dictionary. Fixes, or at least improves, issues/bugs such as e.g. 6658, 6901, 7182, 7217, bug 917796, bug 1242142.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://107.22.172.223:8877/869e65ff356723d/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7fc9faef00f3671/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/869e65ff356723d/output.txt Total script time: 24.15 mins
Image differences available at: http://107.22.172.223:8877/869e65ff356723d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/7fc9faef00f3671/output.txt Total script time: 38.38 mins
Image differences available at: http://107.21.233.14:8877/7fc9faef00f3671/reftest-analyzer.html#web=eq.log |
|
Looks good to me. The code is actually quite understandable even though I'm not too familiar with the font code. It's really nice to notice that the tests now cover this well and show clear improvements. It's a good issue closer, so nice work! /cc @brendandahl or @yurydelendik for review |
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c3d58a1d0221614/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/27efc522ab2527d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/27efc522ab2527d/output.txt Total script time: 24.37 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c3d58a1d0221614/output.txt Total script time: 37.73 mins
|
|
@brendandahl Thank you for the review! |
…iltInEncoding-fallback For embedded Type1 fonts without included `ToUnicode`/`Encoding` data, attempt to improve text selection by using the `builtInEncoding` to amend the `toUnicode` map (issue 6901, issue 7182, issue 7217, bug 917796, bug 1242142)
Note that in order to prevent any possible issues, this patch does not try to amend the
toUnicodedata for Type1 fonts that contain eitherToUnicodeorEncodingentries in the font dictionary.Fixes, or at least improves, issues/bugs such as e.g. #6658, #6901, #7182, #7217, bug 917796, bug 1242142.