Change the GoToPage Named Action to select the contents of the pageNumber input, rather than just focusing the element
#7583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
GoToPage Named Action to select the contents of the pageNumber input, rather than just focusing it elementGoToPage Named Action to select the contents of the pageNumber input, rather than just focusing the element
…eNumber` input, rather than just focusing the element When clicking on the `pageNumber` input, or when using the keyboard shortcut <kbd>Ctrl</kbd>+<kbd>Alt</kbd>+<kbd>G</kbd>, the element isn't just focused but its contents is actually *selected* so that the user doesn't need to clear the input before entering a new `pageNumber`. However, the `GoToPage` named action is only using `focus`, so let's change this to be consistent. The following document can be used for testing: http://www2.informatik.uni-freiburg.de/~frank/ENG/beamer/example/Beamer-class-example1.pdf#zoom=page-fit [screeenshot]
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5b83c4314969278/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5b83c4314969278/output.txt Total script time: 1.07 mins Published |
|
Good UX improvement, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on the
pageNumberinput, or when using the keyboard shortcut Ctrl+Alt+G, the element isn't just focused but its contents is actually selected so that the user doesn't need to clear the input before entering a newpageNumber.However, the
GoToPagenamed action is only usingfocus, so let's change this to be consistent.The following document can be used for testing: http://www2.informatik.uni-freiburg.de/~frank/ENG/beamer/example/Beamer-class-example1.pdf#zoom=page-fit