Ignore reserved commands when parsing operands in CFFParser_parseDict, instead of just rejecting the entire font (bug 1308536)
#7698
Conversation
|
Could we do a unit test for this instead? |
…t`, instead of just rejecting the entire font (bug 1308536) According to the CFF specification, see http://partners.adobe.com/public/developer/en/font/5176.CFF.pdf#page=11, certain commands are currently reserved. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1308536.
I've tried to (very quickly) put together a simple unit-test for this, but considering that its scope is perhaps a bit limited, I still want to keep the reference test as well to ensure proper test coverage here. /botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/3eced6a5f9a7163/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/bbc1bf454770f72/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/bbc1bf454770f72/output.txt Total script time: 26.25 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/3eced6a5f9a7163/output.txt Total script time: 38.09 mins
|
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a39e4ca1bc82fa4/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b098264663ec995/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/a39e4ca1bc82fa4/output.txt Total script time: 25.82 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b098264663ec995/output.txt Total script time: 37.69 mins
|
|
Landing with r=bdahl on IRC. |
Ignore reserved commands when parsing operands in `CFFParser_parseDict`, instead of just rejecting the entire font (bug 1308536)
According to the CFF specification, see http://partners.adobe.com/public/developer/en/font/5176.CFF.pdf#page=11, certain commands are currently reserved.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1308536.