Let finishPaintTask in pdf_page_view.js return a promise instead, to avoid having to throw in the paintTask.promise rejection handler, and don't reject the PDFPageView_draw promise when rendering is cancelled
#7829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yurydelendik Gentle review ping? |
…o avoid having to throw in the `paintTask.promise` rejection handler, and don't reject the `PDFPageView_draw` promise when rendering is `cancelled` As mentioned on IRC yesterday, we currently throw even when rendering is `cancelled`, which is annoying when the devtools are active. Furthermore, since `cancelled` isn't really an error, rejecting the `PDFPageView_draw` promise seems somewhat strange in that case.
|
@timvandermeij Since I'm not sure how much time Yury has for PDF.js, is this something that you feel comfortable reviewing? Please note that "no" is a perfectly valid answered here! For some more context, the IRC discussion mentioned above: http://logs.glob.uno/?c=mozilla%23pdfjs&s=18+Nov+2016&e=18+Nov+2016#c54305. |
timvandermeij
requested review from
timvandermeij
and removed request for
yurydelendik
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1e0d0cb7379fbe0/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1e0d0cb7379fbe0/output.txt Total script time: 2.22 mins Published |
timvandermeij
approved these changes
Dec 27, 2016
|
Thank you for the patch! |
|
@timvandermeij Thanks so much for landing this; the throwing on |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…omise Let `finishPaintTask` in pdf_page_view.js return a promise instead, to avoid having to throw in the `paintTask.promise` rejection handler, and don't reject the `PDFPageView_draw` promise when rendering is `cancelled`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on IRC yesterday, we currently throw even when rendering is
cancelled, which is annoying when the devtools are active. Furthermore, sincecancelledisn't really an error, rejecting thePDFPageView_drawpromise seems somewhat strange in that case.Perhaps marginally easier reviewing with https://github.com/mozilla/pdf.js/pull/7829/files?w=1.
This change is