[Firefox addon] Change the minimum supported version to Firefox 45, i.e. the current ESR version, and remove no longer necessary fallback code #7913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….e. the current ESR version, and remove no longer necessary fallback code According to https://wiki.mozilla.org/RapidRelease/Calendar#Past_branch_dates: The *last* ESR version of Firefox 38 was released in April this year, and since June the only available ESR version has been based on Firefox 45. Now that Seamonkey has *finally* released a new version, i.e. 2.46 which should correspond to Firefox 49, there doesn't seem to be any reason to keep the fallback code around in the addon anymore.
… Firefox versions 36 (and below) from `PdfJsTelemetry-addon.jsm` Given that the addon doesn't even work in Firefox versions prior to 38, this is just dead code that can now be removed.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1d98f5c8fc622d8/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1d98f5c8fc622d8/output.txt Total script time: 2.15 mins Published |
|
@yurydelendik Could you review this? It would be nice to get rid of all that fallback code. |
|
Thank you for the patch |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…fox45 [Firefox addon] Change the minimum supported version to Firefox 45, i.e. the current ESR version, and remove no longer necessary fallback code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Firefox addon] Change the minimum supported version to Firefox 45, i.e. the current ESR version, and remove no longer necessary fallback code
[Firefox addon] Remove the
registerAddonHistogramfallback code for Firefox versions 36 (and below) fromPdfJsTelemetry-addon.jsmNote that this PR lets us remove all the current fallback code from the Firefox addon!
Also, this time I made sure to take the updated version numbers from https://addons.mozilla.org/en-US/firefox/pages/appversions/ to prevent issues.