[Firefox addon] Enable the consistent-return ESLint rule (issue 7957)
#7995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/52b061ce67debd8/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/52b061ce67debd8/output.txt Total script time: 2.22 mins Published |
Snuffleupagus
changed the title
consistent-return rule (issue 7957)consistent-return ESLint rule (issue 7957)
yurydelendik
approved these changes
Jan 27, 2017
See http://eslint.org/docs/rules/consistent-return; it appears that I overlooked this rule in PR 7982. Also adds the http://eslint.org/docs/rules/no-nested-ternary rule, which didn't require any code changes, since that rule is being enforced in mozilla-central. Re: issue 7957.
|
/botio lint |
From: Bot.io (Linux)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/fba252c080a05bc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c9dd221476816c9/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/fba252c080a05bc/output.txt Total script time: 1.37 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/c9dd221476816c9/output.txt Total script time: 2.42 mins
|
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…stent-return [Firefox addon] Enable the `consistent-return` ESLint rule (issue 7957)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://eslint.org/docs/rules/consistent-return; it appears that I overlooked this rule in PR #7982.
Also adds the http://eslint.org/docs/rules/no-nested-ternary rule, which didn't require any code changes, since that rule is being enforced in mozilla-central.
Re: issue #7957.