Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EOF/isEOF from core/parser.js to core/primitives.js #8003

Merged
merged 1 commit into from
Jan 29, 2017
Merged

Move EOF/isEOF from core/parser.js to core/primitives.js #8003

merged 1 commit into from
Jan 29, 2017

Commits on Jan 27, 2017

  1. Move EOF/isEOF from core/parser.js to core/primitives.js

    Given the nature of `EOF` and `isEOF`, it seems to me that they really ought to be placed in `core/primitives.js` instead.
    
    In general, it doesn't seem great to have to depend on the entire `core/parser.js` file for such simple primitives/helper functions.
    In particular, while `core/ps_parser.js` is completely separate from `core/parser.js` with regards to its function, it still depends on the latter for just *one* primitive.
    
    Note that compared to e.g. PR 7389, this will not reduce the number of dependencies for `core/ps_parser`, however the new dependency IMHO makes more sense.
    Snuffleupagus committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    50c2856 View commit details
    Browse the repository at this point in the history