Commits on Feb 15, 2017

1. Always choose a (3, 1) cmap table for TrueType fonts that have an enc… …

   …oding specified, regardless of the Symbolic font flag (bug 1337429)
   
   This patch basically reverts one aspect of TrueType (3, 1) cmap parsing to the state prior to PR 4259. After that PR, a number of regressions occurred in this particular code-path, which necessitated a number of follow-ups such as PRs 5703, 5743, and 6425.
   The empirical data suggests, at least to me, that we should always prefer a (3, 1) cmap for TrueType fonts when they have an encoding, regardless of the Symbolic font flag.
   
   Obviously this patch passes all unit/font/reference tests locally, and I made sure that all the PRs mentioned above landed with test-cases included.
   However, in my opinion, there's still a very real possibility that this patch could potentially cause new regressions.
   
   Given that the PDF file in bug 1337429 has been broken for almost *three* years before anyone noticed, and considering that the code-path in question has been the source of numerous regressions, I do *not* intend to request uplift of this patch to previous Firefox versions (assuming that it's even accepted).
   
   Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1337429.

   

   Snuffleupagus committed Feb 15, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for ce07202
   • Browse repository at this point

   Copy the full SHA

   ce07202 View commit details

   Browse the repository at this point in the history