Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compatibility code to the shared/compatibility.js. #8102

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

yurydelendik
Copy link
Contributor

Trying to address "Dependency on Promise for legacy browsers" item from #8050 with attempt to provide centralized compatibility file for window and worker files.

The web/compatiblity.js file is not really needed, but will be helpful for people to avoid 404 in nearest future and not break their build scripts. We can remove that later with major version.

@yurydelendik
Copy link
Contributor Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://54.215.176.217:8877/e3f2a49896865f5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/e3f2a49896865f5/output.txt

Total script time: 6.12 mins

Published

@yurydelendik yurydelendik force-pushed the mv-compatibilty branch 3 times, most recently from 474f9f2 to dab622a Compare February 24, 2017 01:10
@yurydelendik
Copy link
Contributor Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://54.215.176.217:8877/fa471fcc862993c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/fa471fcc862993c/output.txt

Total script time: 6.22 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really great to see this happening, since it gets rid of so much stuff from shared/util.js!

r=me, with passing tests.

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2bacddfeb3bb03c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/a16a3e0a1044360/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/a16a3e0a1044360/output.txt

Total script time: 21.88 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/2bacddfeb3bb03c/output.txt

Total script time: 25.81 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 59392fd into mozilla:master Feb 24, 2017
@timvandermeij
Copy link
Contributor

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants