-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move compatibility code to the shared/compatibility.js. #8102
Conversation
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e3f2a49896865f5/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/e3f2a49896865f5/output.txt Total script time: 6.12 mins Published |
474f9f2
to
dab622a
Compare
dab622a
to
facefb0
Compare
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/fa471fcc862993c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/fa471fcc862993c/output.txt Total script time: 6.22 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really great to see this happening, since it gets rid of so much stuff from shared/util.js
!
r=me, with passing tests.
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2bacddfeb3bb03c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a16a3e0a1044360/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/a16a3e0a1044360/output.txt Total script time: 21.88 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2bacddfeb3bb03c/output.txt Total script time: 25.81 mins
|
Awesome work! |
Move compatibility code to the shared/compatibility.js.
Trying to address "Dependency on Promise for legacy browsers" item from #8050 with attempt to provide centralized compatibility file for window and worker files.
The web/compatiblity.js file is not really needed, but will be helpful for people to avoid 404 in nearest future and not break their build scripts. We can remove that later with major version.