Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we don't ignore 0 values in Page.getInheritedPageProp (issue 8125) #8126

Merged
merged 1 commit into from
Mar 3, 2017
Merged

Conversation

Snuffleupagus
Copy link
Collaborator

It appears that I accidentally broke this in PR #6065, sorry about that!

The issue in this particular PDF file is that there's /Rotate entries on different levels of the /Pages tree. We're supposed to use the /Rotate entry in the /Page dict (which is 0), but because of an incorrect condition we instead ended up with the one from the /Pages dict (which is 180).

Fixes #8125.

… (issue 8125)

It appears that I accidentally broke this in PR 6065, sorry about that!

The issue in this particular PDF file is that there's `/Rotate` entries on different levels of the `/Pages` tree. We're supposed to use the `/Rotate` entry in the `/Page` dict (which is `0`), but because of an incorrect condition we instead ended up with the one from the `/Pages` dict (which is `180`).

Fixes 8125.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2017

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/74d20b4410ed47a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2017

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/bc89b9a26e4a544/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/bc89b9a26e4a544/output.txt

Total script time: 22.61 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/74d20b4410ed47a/output.txt

Total script time: 28.31 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2017

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/982843fc463739e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2017

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/267f469d44072fd/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/267f469d44072fd/output.txt

Total script time: 21.58 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/982843fc463739e/output.txt

Total script time: 28.42 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus merged commit 24e5b6e into mozilla:master Mar 3, 2017
@Snuffleupagus Snuffleupagus deleted the issue-8125 branch March 3, 2017 21:05
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Ensure that we don't ignore `0` values in `Page.getInheritedPageProp` (issue 8125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants