Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the prefer-promise-reject-errors ESLint rule #8257

Merged
merged 1 commit into from
Apr 8, 2017
Merged

Enable the prefer-promise-reject-errors ESLint rule #8257

merged 1 commit into from
Apr 8, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

See http://eslint.org/docs/rules/prefer-promise-reject-errors, note that this is similar to the already used no-throw-literal rule.

See http://eslint.org/docs/rules/prefer-promise-reject-errors, note that this is similar to the already used  `no-throw-literal` rule.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 8, 2017

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/00921d3cf6f0055/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 8, 2017

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/d86bec99302a3a0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 8, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/d86bec99302a3a0/output.txt

Total script time: 23.66 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 8, 2017

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/00921d3cf6f0055/output.txt

Total script time: 60.00 mins

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux test

@pdfjsbot
Copy link

pdfjsbot commented Apr 8, 2017

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/3914dffa9377ae7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 8, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/3914dffa9377ae7/output.txt

Total script time: 30.61 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit d6dfc26 into mozilla:master Apr 8, 2017
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the eslint_prefer-promise-reject-errors branch April 8, 2017 20:56
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…ise-reject-errors

Enable the `prefer-promise-reject-errors` ESLint rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants