Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves Uint32ArrayView and hasCanvasTypedArrays into compatibility.js. #8283

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

yurydelendik
Copy link
Contributor

Following up on #8155 (comment) comment:

want to remove this construct: let's add inherited from TypedArray three-args constructor for Uint32Array and use new Uint32Array(dest.buffer, 0, dest.buffer.byteLength >> 2) here. We need to add byteLength and buffer properties for window.CanvasPixelArray though. Hopefully we can rid of HasCanvasTypedArraysCached stuff by doing that.

@yurydelendik
Copy link
Contributor Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://54.215.176.217:8877/8c2cee2807e5338/output.txt

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ce48aff808a3e31/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://54.215.176.217:8877/17eff562353036d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/8c2cee2807e5338/output.txt

Total script time: 6.84 mins

Published

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/17eff562353036d/output.txt

Total script time: 23.45 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/ce48aff808a3e31/output.txt

Total script time: 30.82 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/ce48aff808a3e31/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b8b4730f9deb282/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://54.215.176.217:8877/3937700923019c7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/3937700923019c7/output.txt

Total script time: 23.21 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/b8b4730f9deb282/output.txt

Total script time: 30.78 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/b8b4730f9deb282/reftest-analyzer.html#web=eq.log

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up and finishing it!

r=me, with this code removed as well: https://github.com/mozilla/pdf.js/blob/master/src/display/global.js#L299-L305.

@yurydelendik
Copy link
Contributor Author

with this code removed as well: https://github.com/mozilla/pdf.js/blob/master/src/display/global.js#L299-L305.

we cannot fully remove these line from API versioning point of view -- replacing it with const value.

@yurydelendik yurydelendik merged commit f6d4de9 into mozilla:master Apr 14, 2017
@yurydelendik yurydelendik deleted the uint32arrayview branch April 14, 2017 15:39
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Moves Uint32ArrayView and hasCanvasTypedArrays into compatibility.js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants