Moves 'web' target to the gulpfile. #8288
Conversation
gulpfile.js
Outdated
| .pipe(gulp.dest(GH_PAGES_DIR + EXTENSION_SRC_DIR + 'chromium/')), | ||
| gulp.src('test/features/**/*', {base: 'test/'}) | ||
| .pipe(gulp.dest(GH_PAGES_DIR)), | ||
| gulp.src(JSDOC_DIR + '**/*', {base: JSDOC_DIR}) |
There was a problem hiding this comment.
I was puzzled as to why this folder, https://github.com/mozilla/pdf.js/tree/gh-pages/api/draft, wasn't copied over when testing locally.
It seems to me that we should add var JSDOC_BUILD_DIR = BUILD_DIR + 'jsdoc/'; to the other constants at the top of the file, and then use that here instead.
Bonus points if this new constant is also used at https://github.com/mozilla/pdf.js/blob/master/gulpfile.js#L932 as well :-)
gulpfile.js
Outdated
| FIREFOX_BUILD_DIR + '*.rdf']) | ||
| .pipe(gulp.dest(GH_PAGES_DIR + EXTENSION_SRC_DIR + 'firefox/')), | ||
| gulp.src([CHROME_BUILD_DIR + '*.crx', | ||
| FIREFOX_BUILD_DIR + '*.rdf']) |
There was a problem hiding this comment.
I know that you're just moving the old code over, but after looking at this line:
Why are we copying files, relevant to the FIREFOX addon, into a folder that ought to contain the CHROMIUM extension!?
gulpfile.js
Outdated
| spawnSync('git', ['remote', 'add', 'origin', REPO], {cwd: GH_PAGES_DIR}); | ||
| spawnSync('git', ['add', '-A'], {cwd: GH_PAGES_DIR}); | ||
| spawnSync('git', [ | ||
| 'commit', '-am', 'gh-pages site created via make.js script', |
There was a problem hiding this comment.
Nit: Replace make.js with gulpfile.js here.
gulpfile.js
Outdated
| @@ -48,11 +50,15 @@ var COMPONENTS_DIR = BUILD_DIR + 'components/'; | |||
| var SINGLE_FILE_DIR = BUILD_DIR + 'singlefile/'; | |||
| var MINIFIED_DIR = BUILD_DIR + 'minified/'; | |||
| var FIREFOX_BUILD_DIR = BUILD_DIR + 'firefox/'; | |||
| var CHROME_BUILD_DIR = BUILD_DIR + '/chromium/'; | |||
There was a problem hiding this comment.
Nit: For consistency with the other lines, the first slash can be removed.
gulpfile.js
Outdated
| @@ -48,11 +50,15 @@ var COMPONENTS_DIR = BUILD_DIR + 'components/'; | |||
| var SINGLE_FILE_DIR = BUILD_DIR + 'singlefile/'; | |||
| var MINIFIED_DIR = BUILD_DIR + 'minified/'; | |||
| var FIREFOX_BUILD_DIR = BUILD_DIR + 'firefox/'; | |||
| var CHROME_BUILD_DIR = BUILD_DIR + '/chromium/'; | |||
There was a problem hiding this comment.
Remove the extra slash before chromium for consistency with the other variables above it.
gulpfile.js
Outdated
| FIREFOX_BUILD_DIR + '*.rdf']) | ||
| .pipe(gulp.dest(GH_PAGES_DIR + EXTENSION_SRC_DIR + 'firefox/')), | ||
| gulp.src([CHROME_BUILD_DIR + '*.crx', | ||
| FIREFOX_BUILD_DIR + '*.rdf']) |
There was a problem hiding this comment.
This does not look right. Why would the Chome extension folder need to contain the Firefox .rdf file?
gulpfile.js
Outdated
| }); | ||
|
|
||
| gulp.task('wintersmith', ['gh-pages-prepare'], function (done) { | ||
| mkdirp.sync(GH_PAGES_DIR); |
There was a problem hiding this comment.
Shouldn't this already exist because gh-pages-prepare is a prerequisite here?
yurydelendik
force-pushed
the
mv-make-web
branch
from
1681ab7
to
89df5ef
Compare
|
Nice work, thanks! |
|
/botio-windows preview |
Moves 'web' target to the gulpfile.
No description provided.