Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the files in the /src/display folder to ES6 modules #8294

Merged
merged 1 commit into from
Apr 16, 2017
Merged

Convert the files in the /src/display folder to ES6 modules #8294

merged 1 commit into from
Apr 16, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Apr 16, 2017

Also disables ES2015 transpilation in development mode. Edit: This doesn't seem to improve the performance very much, but at least it cannot hurt.


As discussed on IRC, here's a PR that only converts the /src/display folder to ES6 modules, since it's currently infeasible to convert the rest of the /src code due to slowness of the SystemJS module loader.

Easier reviewing with: https://github.com/mozilla/pdf.js/pull/8294/files?w=1.

Also disables ES2015 transpilation in development mode.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ddb7f2f3857cfae/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/fc8b3e4ac7c5ada/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/fc8b3e4ac7c5ada/output.txt

Total script time: 24.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/ddb7f2f3857cfae/output.txt

Total script time: 60.00 mins

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c2c70f05511f9dd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/c2c70f05511f9dd/output.txt

Total script time: 30.67 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/c2c70f05511f9dd/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/67cb6639cd4af19/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/67cb6639cd4af19/output.txt

Total script time: 2.89 mins

Published

@timvandermeij timvandermeij merged commit 228df57 into mozilla:master Apr 16, 2017
@timvandermeij
Copy link
Contributor

Awesome work!

@Snuffleupagus Snuffleupagus deleted the es6-modules-src-display branch April 16, 2017 22:12
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…splay

Convert the files in the `/src/display` folder to ES6 modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants