Makefile: remove unused mozcentralcheck target
#8328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not used by upstream anymore, since they create a diff and manually review it before submitting it.
|
@rvandermeulen Can you please confirm that you're not using |
|
I am not! Just mozcentralbaseline and mozcentraldiff.
…On Apr 25, 2017 7:58 AM, "Jonas Jenwald" ***@***.***> wrote:
@rvandermeulen <https://github.com/rvandermeulen> Can you please confirm
that you're not using gulp mozcentralcheck when doing the PDF.js updates
on mozilla-central, so that we don't accidentally break your work-flow by
removing this code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8328 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADfdv7HA0XtwRgInP5A91ER5URsoF9_Fks5rzd_lgaJpZM4NGtZH>
.
|
Thanks for the very speedy response! |
|
@timvandermeij Thank you for removing this dead code! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…heck Makefile: remove unused `mozcentralcheck` target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not used by upstream anymore, since they create a diff and manually review it before submitting it.