Enable the object-shorthand ESLint rule
#8353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see http://eslint.org/docs/rules/object-shorthand. Unfortunately, based on commit 9276d1d, it seems that we still need to maintain compatibility with old Node.js versions, hence certain files/directories that are executed in Node.js are currently exempt from this rule. Furthermore, since the files specific to the Chromium extension are not run through Babel, the `/extensions/chromium/` directory is also exempt from this rule.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4eb3649f32b18ee/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ad18978cc9c6a8b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/ad18978cc9c6a8b/output.txt Total script time: 21.25 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/4eb3649f32b18ee/output.txt Total script time: 35.14 mins
Image differences available at: http://107.21.233.14:8877/4eb3649f32b18ee/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Apr 30, 2017
|
Looks good, thanks! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…thand Enable the `object-shorthand` ESLint rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see http://eslint.org/docs/rules/object-shorthand. Note: This is another part of issue #7957.
Unfortunately, based on commit 9276d1d, it seems that we still need to maintain compatibility with old Node.js versions, hence certain files/directories that are executed in Node.js are currently exempt from this rule.
Furthermore, since the files specific to the Chromium extension are not run through Babel, the
/extensions/chromium/directory is also exempt from this rule.