Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds special case for origin of blob to the compatibility URL. #8515

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

yurydelendik
Copy link
Contributor

Fixes #7089

case 'blob':
// Special case of blob: -- returns valid origin of _schemaData.
try {
return new JURL(this._schemaData).origin || 'null';
Copy link
Collaborator

@Snuffleupagus Snuffleupagus Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you mean this._schemeData here, since the above property is always undefined (applies in the comment below as well)!?

@yurydelendik
Copy link
Contributor Author

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://54.215.176.217:8877/ac43cab638216dc/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/ac43cab638216dc/output.txt

Total script time: 18.01 mins

Published

@yurydelendik
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 1

Live output at: http://54.67.70.0:8877/846491c8c20987d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/846491c8c20987d/output.txt

Total script time: 2.17 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfectly reasonable to me, but I haven't got the necessary hardware to test that it actually fixes the referenced issue.

@yurydelendik If you've successfully tested this, please feel free to land the patch!

@yurydelendik
Copy link
Contributor Author

but I haven't got the necessary hardware to test that it actually fixes the referenced issue.

I tried using polyfill with blob URL on IE9, and it worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants