Split the existing ColorSpace in two classes, a private ColorSpace and a public ColorSpaceFactory, and utilize the latter in PDFDocument to allow various code to access the methods of ColorSpace
#8978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ColorSpace` will now only contain the static methods, while the others are moved to the new `BaseAbstractCS` class which the various colour space classes will inherit from. To reduce duplication, we're now using `Util.inherit` for all the classes that "extends" the new `BaseAbstractCS`.
…ather than a bunch of (somewhat) randomly ordered parameters
…` and a public `ColorSpaceFactory`, and utilize the latter in `PDFDocument` to allow various code to access the methods of `ColorSpace` *Follows the same pattern as PR 8968.*
…ns where it's no longer necessary In quite a few `src/core` files we were passing in `xref` to various code, only because `ColorSpace` or `PDFFunction` needed it. Since that has now been re-factored, we can simplify the affected signatures.
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/101cab4ec2f3df0/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9b78318776de602/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9b78318776de602/output.txt Total script time: 16.93 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/101cab4ec2f3df0/output.txt Total script time: 23.32 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the same pattern as PR #8968.