-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mispelled isEvalSupported property at FontFaceObject() creation. #9008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice catch! Especially considering that the typo actually causes worse performance, since it prevents the fast-path in FontFaceObject.getPathGenerator
from being used.
r=me, with passing tests.
Thank you for spotting, and fixing, this long-standing bug!
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/42d80a9a6b988a1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/14eddcf09c08fef/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/42d80a9a6b988a1/output.txt Total script time: 16.66 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/14eddcf09c08fef/output.txt Total script time: 23.44 mins
|
Nice find! |
Mispelled isEvalSupported property at FontFaceObject() creation.
Hello,
While looking at the code for available options..i've found a typo when creating the
FontFaceObject()
instances, the providedisEvalSuported
option should actually beisEvalSupported
(note the extrap
)Not sure if that would be causing any real issue since there is a fallback logic, but anyway i thought you may want that fixed, fwiw it got introduced over two years ago on commit 1d12aed
Cheers.