-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed decodeURI to decodeURIComponent: Fixes #8987 #9364
changed decodeURI to decodeURIComponent: Fixes #8987 #9364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @timvandermeij can you please have a look and run the tests to see if we are good to go.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c72690391793dbb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/47644de70f0b947/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/47644de70f0b947/output.txt Total script time: 23.30 mins
Image differences available at: http://54.215.176.217:8877/47644de70f0b947/reftest-analyzer.html#web=eq.log |
@timvandermeij you have any idea why are these tests failing on windows?? |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c72690391793dbb/output.txt Total script time: 38.15 mins
|
Thank you for fixing this! Note that the reference test failure is a known intermittent problem and can be ignored for this patch. |
oh thanx a lot @timvandermeij @mukulmishra18 😄 |
…decodeURIcomponent changed decodeURI to decodeURIComponent: Fixes mozilla#8987
pdf.js node extension now opens file containing the character
#
in the file name or the path of the file.Read the following snippet from here
Solves #8987
Thank you @mukulmishra18 for your help.
Please review.