Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert using bulk_create for new projectlocales #3265

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Jun 28, 2024

Fixes #3262

@eemeli eemeli requested a review from mathjazz June 28, 2024 12:31
Copy link
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd just add a comment.

Nice work! And sorry for the extra work. 🦆

pontoon/administration/views.py Show resolved Hide resolved
("firefox-multi-account-containers", "fur"),
("firefox-profiler", "en-CA"),
("firefox-profiler", "fur"),
("firefox-profiler", "tr"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these identified via PermissionChangelog?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No; it doesn't track group permission creations. These are from the following SQL query, which isn't pretty but works:

select a.id as group_id, a.name
from auth_group as a
left join guardian_groupobjectpermission as g on a.id=g.group_id
where g.id is null
  and a.name not like 'terminology%'
  and a.name not like 'tutorial%';

@eemeli eemeli merged commit 7746964 into mozilla:main Jun 28, 2024
2 checks passed
@eemeli eemeli deleted the fix-projectlocale-permissions branch June 28, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly assigned permission changes have no effect
2 participants