Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags section is not displayed in My queries page #475

Closed
madalincm opened this issue Jul 31, 2018 · 6 comments
Closed

Tags section is not displayed in My queries page #475

madalincm opened this issue Jul 31, 2018 · 6 comments
Labels
enhancement verified fixed
Milestone
20

Comments

@madalincm
Copy link

Steps to Reproduce:

  1. Open all queries page: https://pipeline-sql.stage.mozaws.net/queries?page=1
  2. Select My Queries from the right side menu
  3. Observe tags section

Expected results:

Tags are displayed. The user is able to filter own queries by tags

Actual results:

The tags section is not displayed.

Notes/Issues:

Verified in FF61(Win7). Issue can be reproduced in STMO-stage
Please view this screencast:
notagssectionmyqueries
@madalincm madalincm added the bug label Jul 31, 2018
@rafrombrc
Copy link
Member

If this is (as we suspect) missing upstream as well, let's open a PR for this upstream and not block our release on this one.

@rafrombrc rafrombrc added this to the 16 milestone Aug 1, 2018
@rafrombrc rafrombrc added the ready label Aug 1, 2018
@rafrombrc rafrombrc modified the milestones: 16, 17 Aug 9, 2018
@jezdez jezdez mentioned this issue Sep 17, 2018
Closed
@rafrombrc rafrombrc modified the milestones: 17, 18 Nov 7, 2018
@rafrombrc rafrombrc modified the milestones: 18, 19, 20 Nov 8, 2018
@alison985 alison985 self-assigned this Nov 11, 2018
@alison985
Copy link

Issue opened upstream by @jezdez getredash#2828

@alison985 alison985 mentioned this issue Nov 11, 2018
Closed
@alison985
Copy link

PR upstream getredash#3066

@alison985 alison985 added in review in review upstream PR in review in getredash/redash and removed in progress labels Nov 11, 2018
@alison985
Copy link

I closed PR getredash#3066 because the lack of tags on the My Queries page was intentional. The Tags API will need to be extended to support filtering the tags for both the My Queries page and query list search results.

@alison985 alison985 added enhancement and removed bug in review in review upstream PR in review in getredash/redash labels Nov 30, 2018
@alison985 alison985 removed their assignment Nov 30, 2018
@jezdez
Copy link

jezdez commented Feb 6, 2019

Since I've filed getredash#2828 upstream and this can be considered a general feature request I'm closing this ticket.

@jezdez jezdez closed this as completed Feb 6, 2019
@madalincm
Copy link
Author

The tags have been added to the My queries section. I have run some tests and everything seems to work ok. Marking bug as verified fixed.

@MaxMood96 MaxMood96 mentioned this issue Nov 5, 2022
Open
@MaxMood96 MaxMood96 mentioned this issue Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement verified fixed
Projects
None yet
Milestone
20
Development

No branches or pull requests
4 participants
@jezdez @rafrombrc @alison985 @madalincm