add tag list and filters to My Queries page #3066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Nov 12, 2018
There was a problem hiding this comment.
The reason we don't show the tags list on the My Queries page is because the current tags API returns the list of tags for all the queries. It doesn't feel right to show the user this list in the My Queries context, specially considering that we show the number of queries for each tag.
We actually have the same issue with search results now that we show number of queries per tag.
|
@arikfr Any reason not to change the tags API to support these use cases? |
|
@alison985 no real reason. It wasn't included due to time constraints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla#475 and referenced in #2828
This adds the tag list to the My Queries page and allows filtering of the page.