fix static array functions and add test cases #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback / any hope to get this merged? |
gbrail
requested changes
Sep 22, 2017
| @@ -1570,7 +1570,7 @@ else if (start < 0) | |||
| private static Object iterativeMethod(Context cx, IdFunctionObject idFunctionObject, Scriptable scope, | |||
| Scriptable thisObj, Object[] args) | |||
| { | |||
| int id = idFunctionObject.methodId(); | |||
There was a problem hiding this comment.
I get what you're fixing here.
This case is already convoluted enough and the use of "Math.abs" is not going to be obvious to someone else using the code.
Can you add a comment to the effect that this works because at the very bottom of the file, we use negative numbers to represent the non-prototype versions of these functions and we want them all to work? Otherwise this looks good.
There was a problem hiding this comment.
Ok, you are right. Was not really obvious to me also. Will update this later today.
There was a problem hiding this comment.
Have added some inline comments, hope this makes this a bit more clear.
gbrail
approved these changes
Sep 22, 2017
|
Merged #322.
Thanks Greg, next pull request is on the way
RBRi
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the last refactoring of the array functions had introduces a bug. Hope you like the fix and i did the test stuff right.