Improve hashing logic in ScriptableObject for collision resistance. #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move existing hashing code from ScriptableObject to a new class called EmbeddedSlotMap, which is optimized for fast runtime performance. When the size of a particular object passes a threshold, move all of the slots from that to the HashSlotMap class, which uses java.util.HashMap under the covers. This preserves nearly the same performance as the current implementation when objects are the size of the vast number of objects in JavaScript. However, when objects contain keys with thousands or tens of thousands of hash collisions, java.util.HashMap will switch to a tree-based data structure in order to preserve reasonable performance.
gbrail
force-pushed
the
greg-hashing-6
branch
from
ca039c8 to
e4d0025
Compare
|
Replacing with a more comprehensive version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit log and related issue #290 for more information.
This is a big change with big implications, but it seems to be holding up well. V8 benchmarks as well as microbenchmarks are very close to the way that they were before and any differences seem to be generally lost in the noise.