Use new stable total_cmp function to compare floats

mozilla · Jul 11, 2022 · 09ef915 · 09ef915
1 parent 5c0da1d
commit 09ef915
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/macros.rs b/src/macros.rs
@@ -318,9 +318,8 @@ macro_rules! check_metrics {
 
             $(
                 $(
-                    let value: f64 = $true_float_value;
-                    if !value.is_nan() {
-                        assert!((func_space.metrics.$metric.$func_float() - value).abs() < f64::EPSILON);
+                    if !($true_float_value as f64).is_nan() {
+                        assert!(func_space.metrics.$metric.$func_float().total_cmp(&$true_float_value) == std::cmp::Ordering::Equal);
                     } else {
                         assert!(func_space.metrics.$metric.$func_float().is_nan());
                     }

diff --git a/tests/test.rs b/tests/test.rs
@@ -178,7 +178,7 @@ fn compare_f64(f1: f64, f2: &serde_json::Value) {
     } else {
         let ft1 = f64::trunc(f1 * 1000.0) / 1000.0;
         let ft2 = f64::trunc(f2.as_f64().unwrap() * 1000.0) / 1000.0;
-        assert!((ft1 - ft2).abs() < f64::EPSILON);
+        assert!(ft1.total_cmp(&ft2) == std::cmp::Ordering::Equal);
     }
 }