python: Consider boolean operator in tuples for cognitive

mozilla · Mar 8, 2021 · 2a865e7 · 2a865e7
1 parent 8411302
commit 2a865e7
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/src/metrics/cognitive.rs b/src/metrics/cognitive.rs
@@ -222,7 +222,7 @@ impl Cognitive for PythonCode {
             ExceptClause => {
                 increment(stats);
             }
-            ExpressionList | ExpressionStatement => {
+            ExpressionList | ExpressionStatement | Tuple => {
                 stats.boolean_seq.reset();
             }
             NotOperator => {
@@ -497,6 +497,19 @@ mod tests {
         );
     }
 
+    #[test]
+    fn python_tuple() {
+        check_metrics!(
+            "def f(a, b):
+                return \"%s%s\" % (a and \"Get\" or \"Set\", b)",
+            "foo.py",
+            PythonParser,
+            cognitive,
+            [(cognitive, 2, usize)],
+            [(cognitive_average, 2.0)]
+        );
+    }
+
     #[test]
     fn python_elif_function() {
         check_metrics!(