Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloc metric #130

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Fix cloc metric #130

merged 2 commits into from
Mar 31, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Mar 24, 2020

The current cloc implementation counts blank lines also, this one fixes that problem.

Thanks in advance for your review! :)

calixteman
calixteman approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@calixteman calixteman merged commit 8e12cf2 into mozilla:master Mar 31, 2020
@Luni-4 Luni-4 deleted the fix-cloc branch March 31, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luni-4 @calixteman