Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BLANK metric #142

Merged
merged 4 commits into from
Apr 10, 2020
Merged

Implement BLANK metric #142

merged 4 commits into from
Apr 10, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Apr 6, 2020

This PR implements the BLANK metric that counts the number of blank lines in a source file.

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman April 6, 2020 11:25
@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

Merging #142 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   14.88%   14.87%   -0.01%     
==========================================
  Files          45       45              
  Lines        5764     5767       +3     
  Branches      684      686       +2     
==========================================
  Hits          858      858              
- Misses       4626     4628       +2     
- Partials      280      281       +1     
Impacted Files Coverage Δ
src/loc.rs 35.44% <0.00%> (-0.93%) ⬇️
src/metrics.rs 27.60% <0.00%> (-0.10%) ⬇️
src/web/server.rs 57.10% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c320eac...d6e0899. Read the comment docs.

calixteman
calixteman previously approved these changes Apr 10, 2020
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test

calixteman
calixteman previously approved these changes Apr 10, 2020
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@calixteman
Copy link
Collaborator

Could you rebase please?

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Apr 10, 2020

Could you rebase please?

Done!

@Luni-4 Luni-4 requested a review from calixteman April 10, 2020 11:15
@calixteman calixteman merged commit 86ac7c9 into mozilla:master Apr 10, 2020
@Luni-4 Luni-4 deleted the blank branch April 10, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants