Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Blank metric #151

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix Blank metric #151

merged 1 commit into from
Apr 21, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Apr 14, 2020

  • Fix a strange case for the Blank metric
  • Add a unit test for that

@Luni-4 Luni-4 requested a review from calixteman April 14, 2020 14:31
@codecov-io
Copy link

codecov-io commented Apr 14, 2020 •
edited
Loading

Codecov Report

Merging #151 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   15.30%   15.30%   -0.01%     
==========================================
  Files          45       45              
  Lines        5809     5810       +1     
  Branches      698      699       +1     
==========================================
  Hits          889      889              
  Misses       4626     4626              
- Partials      294      295       +1
Impacted Files Coverage Δ
src/loc.rs 46.66% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963001f...b7d2832. Read the comment docs.

calixteman
calixteman reviewed Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment to explain why we can have blanc < 0.

@Luni-4 Luni-4 requested a review from calixteman April 14, 2020 16:16
@calixteman
Copy link
Collaborator

Can you rebase it please ?

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Apr 20, 2020

Done!

calixteman
calixteman reviewed Apr 20, 2020
View reviewed changes
src/loc.rs Outdated Show resolved Hide resolved
@Luni-4 Luni-4 requested a review from calixteman April 20, 2020 09:44
calixteman
calixteman approved these changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@calixteman calixteman merged commit c610dcd into mozilla:master Apr 21, 2020
@Luni-4 Luni-4 deleted the fix-blank branch April 21, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luni-4 @codecov-io @calixteman