Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy rust-code-analysis for Windows #165

Merged
merged 1 commit into from
May 10, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Apr 30, 2020

This PR fixes #137

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from marco-c April 30, 2020 08:35
@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

Merging #165 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   15.96%   15.92%   -0.04%     
==========================================
  Files          44       44              
  Lines        5437     5437              
  Branches      597      597              
==========================================
- Hits          868      866       -2     
- Misses       4287     4290       +3     
+ Partials      282      281       -1     
Impacted Files Coverage Δ
src/metrics/loc.rs 45.00% <0.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb8f5d...ae5617c. Read the comment docs.

.taskcluster.yml Outdated Show resolved Hide resolved
@Luni-4 Luni-4 force-pushed the deploy-windows branch from 040a7c3 to b686d14 Compare May 7, 2020 09:00
.taskcluster.yml Outdated Show resolved Hide resolved
@Luni-4 Luni-4 requested a review from marco-c May 7, 2020 09:03
@Luni-4 Luni-4 force-pushed the deploy-windows branch from 5be76f4 to 1977396 Compare May 7, 2020 09:44
@Luni-4 Luni-4 removed the request for review from marco-c May 7, 2020 09:44
@Luni-4 Luni-4 force-pushed the deploy-windows branch from 1977396 to 026f2ce Compare May 7, 2020 10:20
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

bad indentation of a sequence entry at line 96, column 56:
... ublic/rust-code-analysis-cli.exe:
^

1 similar comment
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

bad indentation of a sequence entry at line 96, column 56:
... ublic/rust-code-analysis-cli.exe:
^

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

bad indentation of a sequence entry at line 96, column 57:
... ublic/rust-code-analysis-cli.exe:
^

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

bad indentation of a sequence entry at line 96, column 56:
... ublic/rust-code-analysis-cli.exe:
^

@Luni-4 Luni-4 force-pushed the deploy-windows branch from 34e4f55 to e9e0288 Compare May 7, 2020 13:27
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

bad indentation of a mapping entry at line 94, column 17:
file: rustup-init\rustup-init.exe
^

@Luni-4 Luni-4 force-pushed the deploy-windows branch from e9e0288 to 5f7c0af Compare May 7, 2020 13:34
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

bad indentation of a sequence entry at line 96, column 58:
... ublic/rust-code-analysis-cli.exe:
^

@Luni-4 Luni-4 force-pushed the deploy-windows branch 2 times, most recently from 2d35dc9 to d7147ba Compare May 7, 2020 14:18
.taskcluster.yml Outdated Show resolved Hide resolved
.taskcluster.yml Outdated Show resolved Hide resolved
.taskcluster.yml Outdated Show resolved Hide resolved
@Luni-4 Luni-4 force-pushed the deploy-windows branch from d7147ba to b09cda6 Compare May 7, 2020 15:26
.taskcluster.yml Outdated Show resolved Hide resolved
.taskcluster.yml Outdated Show resolved Hide resolved
.taskcluster.yml Outdated Show resolved Hide resolved
.taskcluster.yml Outdated Show resolved Hide resolved
.taskcluster.yml Outdated Show resolved Hide resolved
@Luni-4 Luni-4 force-pushed the deploy-windows branch from b09cda6 to 2b5e383 Compare May 7, 2020 16:16
@Luni-4 Luni-4 force-pushed the deploy-windows branch from 2b5e383 to 6fc090e Compare May 7, 2020 16:32
.taskcluster.yml Outdated Show resolved Hide resolved
@marco-c
Copy link
Collaborator

marco-c commented May 7, 2020

LGTM! Can you apply the last suggested change and revert the removals?

@Luni-4 Luni-4 force-pushed the deploy-windows branch 8 times, most recently from ecc8938 to 994d5df Compare May 9, 2020 11:18
@Luni-4 Luni-4 requested a review from marco-c May 9, 2020 11:19
marco-c
marco-c previously approved these changes May 9, 2020
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-c
Copy link
Collaborator

marco-c commented May 9, 2020

Can you rebase on top of master? There was an issue in the .taskcluster.yml linter that I just fixed.

@marco-c
Copy link
Collaborator

marco-c commented May 9, 2020

(not sure why I can usually rebase PRs myself via GitHub's UI, but I can't with your PRs. Maybe you need to do this: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork).

@marco-c marco-c merged commit 5b51fbf into mozilla:master May 10, 2020
@Luni-4 Luni-4 deleted the deploy-windows branch May 10, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy rust-code-analysis for Windows
3 participants