-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy rust-code-analysis for Windows #165
Conversation
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 15.96% 15.92% -0.04%
==========================================
Files 44 44
Lines 5437 5437
Branches 597 597
==========================================
- Hits 868 866 -2
- Misses 4287 4290 +3
+ Partials 282 281 -1
Continue to review full report at Codecov.
|
Uh oh! Looks like an error! Detailsbad indentation of a sequence entry at line 96, column 56: |
1 similar comment
Uh oh! Looks like an error! Detailsbad indentation of a sequence entry at line 96, column 56: |
Uh oh! Looks like an error! Detailsbad indentation of a sequence entry at line 96, column 57: |
Uh oh! Looks like an error! Detailsbad indentation of a sequence entry at line 96, column 56: |
Uh oh! Looks like an error! Detailsbad indentation of a mapping entry at line 94, column 17: |
Uh oh! Looks like an error! Detailsbad indentation of a sequence entry at line 96, column 58: |
2d35dc9
to
d7147ba
Compare
LGTM! Can you apply the last suggested change and revert the removals? |
ecc8938
to
994d5df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can you rebase on top of master? There was an issue in the .taskcluster.yml linter that I just fixed. |
(not sure why I can usually rebase PRs myself via GitHub's UI, but I can't with your PRs. Maybe you need to do this: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork). |
This PR fixes #137
Thanks in advance for your review! :)