Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a node variant #191

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Add a node variant #191

merged 3 commits into from
Aug 4, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented May 21, 2020

This variant hides the crate used to handle nodes in the code.

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman May 21, 2020 11:13
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #191 into master will increase coverage by 0.33%.
The diff coverage is 48.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   16.82%   17.16%   +0.33%     
==========================================
  Files          46       46              
  Lines        5879     5903      +24     
  Branches      698      698              
==========================================
+ Hits          989     1013      +24     
+ Misses       4490     4488       -2     
- Partials      400      402       +2
Impacted Files Coverage Δ
src/asttools.rs 0.00% <0.00%> (ø)
src/count.rs 0.00% <0.00%> (ø)
src/find.rs 0.00% <0.00%> (ø)
src/macros.rs 51.35% <ø> (ø)
src/metrics/halstead.rs 31.50% <ø> (+2.73%) ⬆️
src/metrics/mi.rs 64.70% <ø> (ø)
src/parser.rs 17.07% <0.00%> (-0.88%) ⬇️
src/preproc.rs 0.00% <0.00%> (ø)
src/metrics/exit.rs 44.68% <25.00%> (ø)
src/checker.rs 36.36% <28.57%> (-1.74%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b6e53...c9b76d9. Read the comment docs.

@Luni-4 Luni-4 force-pushed the node branch 2 times, most recently from 47fbc84 to c281254 Compare May 26, 2020 16:04
@Luni-4 Luni-4 mentioned this pull request May 28, 2020
Merged
@calixteman
Copy link
Collaborator

Is this patch just aim to hide the use tree_sitter::Node; ?
Could you explain the exact rational ?

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jun 1, 2020 •
edited
Loading

Is this patch just aim to hide the use tree_sitter::Node; ?
Could you explain the exact rational ?

Yep, the main goal consists of hiding tree_sitter::Node to users such that the Node struct can be exported in the documentation. I can't avoid showing it because that would mean a lack of documentation.

That's why I wanted to hide the library that handles nodes, and at the same time, the entire tree_sitter library would be completely handled internally by rust-code-analysis

@Luni-4 Luni-4 force-pushed the node branch 3 times, most recently from 2f53ea6 to 862ee71 Compare June 5, 2020 11:13
@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jun 24, 2020

This one seems a bit complicated instead, I couldn't think an alternative solution

@calixteman
Copy link
Collaborator

Please rebase.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jul 2, 2020

Done.

@calixteman calixteman merged commit fdf283d into mozilla:master Aug 4, 2020
@Luni-4 Luni-4 deleted the node branch August 4, 2020 08:17
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
@Luni-4 @spacedragon
Add a node variant (mozilla#191)
6f8fb97 
* Add a node variant

* Use the node variant in the code

* Document node variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman Awaiting requested review from calixteman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luni-4 @codecov-commenter @calixteman