Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the TS prefix for public APIs #192

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented May 22, 2020

Do not use the prefix TS for public APIs

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman May 22, 2020 11:44
@Luni-4 Luni-4 changed the title Remove the TS prefix for our public APIs Remove the TS prefix for public APIs May 22, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #192 into master will decrease coverage by 0.25%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   16.67%   16.42%   -0.26%     
==========================================
  Files          46       46              
  Lines        5840     5840              
  Branches      696      696              
==========================================
- Hits          974      959      -15     
- Misses       4466     4484      +18     
+ Partials      400      397       -3     
Impacted Files Coverage Δ
src/count.rs 0.00% <0.00%> (ø)
src/find.rs 0.00% <0.00%> (ø)
src/macros.rs 51.35% <ø> (ø)
src/output/dump.rs 47.88% <0.00%> (ø)
src/comment_rm.rs 50.00% <50.00%> (ø)
src/function.rs 20.00% <50.00%> (ø)
src/spaces.rs 59.12% <50.00%> (ø)
rust-code-analysis-cli/src/web/comment.rs 35.71% <100.00%> (ø)
rust-code-analysis-cli/src/web/function.rs 30.76% <100.00%> (ø)
rust-code-analysis-cli/src/web/metrics.rs 36.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c81990...4a64acf. Read the comment docs.

@Luni-4 Luni-4 mentioned this pull request May 28, 2020
@Luni-4 Luni-4 force-pushed the rename-trait branch 3 times, most recently from 2daded5 to 8945456 Compare June 5, 2020 10:31
@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jun 5, 2020

Rebased and ready to be merged

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jun 24, 2020

@calixteman

Can we merge this one?

@calixteman calixteman merged commit 76b01b0 into mozilla:master Jun 24, 2020
@calixteman
Copy link
Collaborator

thanks

@Luni-4 Luni-4 deleted the rename-trait branch August 4, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants