Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make preprocess function thread-independent #206

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jun 3, 2020

This PR makes the preprocess function thread-independent.

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman June 3, 2020 07:59
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #206 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   16.49%   16.45%   -0.04%     
==========================================
  Files          46       46              
  Lines        5839     5840       +1     
  Branches      697      697              
==========================================
- Hits          963      961       -2     
- Misses       4476     4480       +4     
+ Partials      400      399       -1     
Impacted Files Coverage Δ
rust-code-analysis-cli/src/main.rs 0.00% <0.00%> (ø)
src/preproc.rs 0.00% <0.00%> (ø)
src/metrics/loc.rs 44.62% <0.00%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfee1bd...0e4f30d. Read the comment docs.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jun 5, 2020

Rebased and ready to be merged.

Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@calixteman calixteman merged commit 4ba762c into mozilla:master Jun 23, 2020
@Luni-4 Luni-4 deleted the fix-preproc branch June 23, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants