-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy documentation automatically #211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 16.58% 15.79% -0.79%
==========================================
Files 46 46
Lines 5832 5832
Branches 695 695
==========================================
- Hits 967 921 -46
- Misses 4465 4521 +56
+ Partials 400 390 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a task that builds the documentation (which we run all the time), and then the release task will publish it (getting the documentation artifact from the first task).
I agree on the documentation task (for |
We should check how big it is, I would expect it to be relatively small given that the documentation is mostly text. |
Ok, checked the size: 1,7MB. But why can't we run the script in the release task? After all, we are uploading the output of |
It's better to have logical separation between the tasks: one task does the build (in this case documentation build), another task (very lightweight) deploys it (in this case on gh-pages). |
7d86ee2
to
40243a1
Compare
f1b3f28
to
1cef10b
Compare
d6be04d
to
78bc2a4
Compare
78bc2a4
to
7c8ac93
Compare
@marco-c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Once we release, the documentation is deployed automatically.
Thanks in advance for your review! :)