Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Halstead metric #223

Merged

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jun 25, 2020

Create functions for each language to detect if a node is an Operator or an Operands.

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman June 25, 2020 07:44
@codecov-commenter
Copy link

Codecov Report

Merging #223 into master will increase coverage by 0.12%.
The diff coverage is 37.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   16.67%   16.80%   +0.12%     
==========================================
  Files          46       46              
  Lines        5840     5873      +33     
  Branches      696      696              
==========================================
+ Hits          974      987      +13     
- Misses       4466     4487      +21     
+ Partials      400      399       -1     
Impacted Files Coverage Δ
src/getter.rs 30.83% <36.50%> (+2.17%) ⬆️
src/metrics/halstead.rs 28.35% <42.85%> (-0.22%) ⬇️
src/metrics/loc.rs 45.00% <0.00%> (-1.67%) ⬇️
src/output/dump_metrics.rs 33.33% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b01b0...19afa14. Read the comment docs.

@calixteman calixteman merged commit 2d75c2d into mozilla:master Jun 25, 2020
@Luni-4 Luni-4 deleted the halstead-new-implementation branch June 25, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants