Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a general loc test #254

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Add a general loc test #254

merged 1 commit into from
Sep 14, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jul 30, 2020

This PR adds a more general test for the Loc metric

It should be merged after #239

@Luni-4 Luni-4 requested a review from marco-c July 30, 2020 11:37
marco-c
marco-c previously approved these changes Aug 6, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #254 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   17.67%   17.70%   +0.02%     
==========================================
  Files          46       46              
  Lines        5963     5966       +3     
  Branches      707      708       +1     
==========================================
+ Hits         1054     1056       +2     
  Misses       4498     4498              
- Partials      411      412       +1     
Impacted Files Coverage Δ
src/metrics/loc.rs 47.61% <66.66%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2176b92...e793dcd. Read the comment docs.

@calixteman calixteman merged commit f8ccc51 into mozilla:master Sep 14, 2020
@Luni-4 Luni-4 deleted the loc-test branch September 14, 2020 11:29
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants