Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mi metric #258

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Fix Mi metric #258

merged 2 commits into from
Aug 5, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Aug 5, 2020

The new Halstead implementation has broken the Mi computation, this PR fixes it. Added a test to simplify catching these errors also.

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman August 5, 2020 09:26
@codecov-commenter
Copy link

Codecov Report

Merging #258 into master will increase coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   17.32%   17.37%   +0.05%     
==========================================
  Files          46       46              
  Lines        5918     5923       +5     
  Branches      698      699       +1     
==========================================
+ Hits         1025     1029       +4     
  Misses       4490     4490              
- Partials      403      404       +1     
Impacted Files Coverage Δ
src/metrics/mi.rs 60.60% <66.66%> (+0.60%) ⬆️
src/spaces.rs 59.73% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967304c...292a59a. Read the comment docs.

@calixteman calixteman merged commit 580a8bc into mozilla:master Aug 5, 2020
@Luni-4 Luni-4 deleted the fix-mi branch August 5, 2020 15:25
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
* Fix Mi metric

* Add Mi test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants