Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mi test #260

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Update Mi test #260

merged 1 commit into from
Sep 14, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Aug 6, 2020

Use the new cyclomatic implementation to test the Mi metric

@Luni-4 Luni-4 requested a review from calixteman August 6, 2020 08:08
Use the new cyclomatic implementation to test the Mi metric
@codecov-commenter
Copy link

Codecov Report

Merging #260 into master will increase coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   17.47%   17.52%   +0.05%     
==========================================
  Files          46       46              
  Lines        5940     5945       +5     
  Branches      706      707       +1     
==========================================
+ Hits         1038     1042       +4     
  Misses       4492     4492              
- Partials      410      411       +1     
Impacted Files Coverage Δ
rust-code-analysis-cli/src/web/server.rs 56.77% <ø> (ø)
src/metrics/mi.rs 60.60% <66.66%> (+0.60%) ⬆️
src/spaces.rs 59.73% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580a8bc...5369a14. Read the comment docs.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Sep 2, 2020

@calixteman

This PR fixes the broken CI, so we can land it anytime

@calixteman calixteman merged commit 2f831ae into mozilla:master Sep 14, 2020
@Luni-4 Luni-4 deleted the fix-mi branch September 14, 2020 08:12
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Use the new cyclomatic implementation to test the Mi metric
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants