Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print metrics on shell without the output parameter #271

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Sep 17, 2020

Metrics needed a useless output parameter to be printed on shell

Thanks in advance for your review! :)

Metrics needed a useless output parameter to be printed on shell.
@Luni-4 Luni-4 requested a review from calixteman September 17, 2020 08:19
@codecov-commenter
Copy link

Codecov Report

Merging #271 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   17.67%   17.70%   +0.02%     
==========================================
  Files          46       46              
  Lines        5963     5966       +3     
  Branches      707      708       +1     
==========================================
+ Hits         1054     1056       +2     
  Misses       4498     4498              
- Partials      411      412       +1     
Impacted Files Coverage Δ
rust-code-analysis-cli/src/main.rs 0.00% <ø> (ø)
src/metrics/loc.rs 47.61% <66.66%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ccc51...4af2189. Read the comment docs.

@calixteman calixteman merged commit d9f724b into mozilla:master Oct 5, 2020
@Luni-4 Luni-4 deleted the fix-metric-output branch October 5, 2020 08:02
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Metrics needed a useless output parameter to be printed on shell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants