Test rust-code-analysis-cli on mozilla-central

[Luni-4]

This PR fixes #39

Thanks in advance for your review!

[codecov-io]

Codecov Report

Merging #290 (cf080ed) into master (73a0931) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   19.89%   20.10%   +0.21%     
==========================================
  Files          47       48       +1     
  Lines        6163     6177      +14     
  Branches      800      799       -1     
==========================================
+ Hits         1226     1242      +16     
+ Misses       4423     4420       -3     
- Partials      514      515       +1     

Impacted Files	Coverage Δ
src/getter.rs	46.75% <0.00%> (-0.44%)	⬇️
src/tools.rs	54.22% <0.00%> (-0.23%)	⬇️
src/lib.rs	100.00% <0.00%> (ø)
rust-code-analysis-cli/src/main.rs	0.34% <0.00%> (+0.34%)	⬆️
rust-code-analysis-cli/src/web/server.rs	58.91% <0.00%> (+1.84%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a0931...cf080ed. Read the comment docs.

[community-tc-integration]

Uh oh! Looks like an error! Details

InterpreterError at template.tasks[1].payload.command[2]: unknown context value mozilla_central

[Luni-4]

@marco-c

I think there is a cache problem somewhere

[marco-c]

I think there is a cache problem somewhere

Maybe an earlier task failed while cloning the repo, so the directory exists but it is not a valid repository.
You'd need to catch this case too. Writing a little separate script to handle the cloning might be easier than trying to do it all in the task definition.

[Luni-4]

Maybe an earlier task failed while cloning the repo, so the directory exists but it is not a valid repository.
You'd need to catch this case too. Writing a little separate script to handle the cloning might be easier than trying to do it all in the task definition.

That could be an idea, but I guess it happened because of the wrong commands I set up earlier. In the meanwhile, I tried to delete the empty directory but without success. Is there a way to clean up the cache in case of errors?

[marco-c]

Oh wait, I know what's wrong. You are mounting the cache on the "/gecko-dev" path, so "/gecko-dev" will always exist (it's the cache!).
You should have a dir such as "/cache", and then clone the repo inside that directory (so "/cache/gecko-dev").

[Luni-4]

Now it seems to work but it doesn't cache anything, it clones the repo every time I force push

[Luni-4]

@marco-c

Is there anything that should be added in this PR? Just a note, I wasn't able to cache the repository on force push, but I guess it's an expected behavior

[marco-c]

Is there anything that should be added in this PR? Just a note, I wasn't able to cache the repository on force push, but I guess it's an expected behavior

It should work :S
I'm not sure why it's not!

Anyway, I'm thinking maybe we should only run the task on releases rather than on every push/PR, especially until we manage to properly use the cache. Can you make the change? (also make the deployment task depend on this newly added task).

[Luni-4]

Anyway, I'm thinking maybe we should only run the task on releases rather than on every push/PR, especially until we manage to properly use the cache. Can you make the change? (also make the deployment task depend on this newly added task).

Done