Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify variable names #306

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Oct 26, 2020

Replace n_args with nargs and n_exits with nexits

Does this PR solve your issue, @calixteman?

@Luni-4 Luni-4 requested a review from calixteman October 26, 2020 21:24
@codecov-io
Copy link

Codecov Report

Merging #306 into master will not change coverage.
The diff coverage is 63.63%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   19.87%   19.87%           
=======================================
  Files          47       47           
  Lines        6163     6163           
  Branches      800      800           
=======================================
  Hits         1225     1225           
  Misses       4423     4423           
  Partials      515      515           
Impacted Files Coverage Δ
src/output/dump_metrics.rs 32.88% <33.33%> (ø)
src/metrics/fn_args.rs 70.58% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d352880...8f428f8. Read the comment docs.

@Luni-4 Luni-4 requested a review from marco-c November 11, 2020 13:16
@marco-c marco-c merged commit 986344e into mozilla:master Nov 11, 2020
@Luni-4 Luni-4 deleted the fix-nargs-name branch November 11, 2020 13:36
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants