Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Nargs metrics between spaces #308

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Oct 29, 2020

It might be helpful to know the number of function/closure arguments present in a space, that's why a merge function for the NArgs metric has been added.

Thanks in advance for your review! :)

@marco-c
Copy link
Collaborator

marco-c commented Nov 11, 2020

@Luni-4 can you rebase this on top of master?

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Nov 11, 2020

@Luni-4 can you rebase this on top of master?

Done

@codecov-io
Copy link

Codecov Report

Merging #308 (1495b3c) into master (0b7ef7e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   20.09%   20.11%   +0.02%     
==========================================
  Files          48       48              
  Lines        6177     6179       +2     
  Branches      799      799              
==========================================
+ Hits         1241     1243       +2     
  Misses       4421     4421              
  Partials      515      515              
Impacted Files Coverage Δ
src/metrics/fn_args.rs 72.22% <100.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7ef7e...1495b3c. Read the comment docs.

@marco-c
Copy link
Collaborator

marco-c commented Nov 11, 2020

Could you add a test?

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Nov 11, 2020

Could you add a test?

Can I add it in another PR? Because perhaps I found a bug, so I can add tests in one fell swoop

@marco-c
Copy link
Collaborator

marco-c commented Nov 11, 2020

Can I add it in another PR? Because perhaps I found a bug, so I can add tests in one fell swoop

It's preferable to add tests in the same PR, but let's make an exception this time ;)

@marco-c marco-c merged commit 7f33ab1 into mozilla:master Nov 11, 2020
@Luni-4 Luni-4 deleted the merge-nargs branch November 11, 2020 13:57
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants