Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count closures arguments for the NArgs metric #352

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Count closures arguments for the NArgs metric #352

merged 2 commits into from
Sep 16, 2021

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Nov 13, 2020 •
edited
Loading

Depends on #373

This PR fixes #342

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from marco-c November 13, 2020 17:23
marco-c
marco-c reviewed Nov 16, 2020
View reviewed changes
src/output/dump_metrics.rs Outdated Show resolved Hide resolved
@Luni-4 Luni-4 force-pushed the lambda-args branch 2 times, most recently from e5183c3 to 7e8a531 Compare November 26, 2020 10:12
@Luni-4 Luni-4 requested a review from marco-c November 26, 2020 10:14
@codecov-io
Copy link

Codecov Report

Merging #352 (7e8a531) into master (3b6afee) will increase coverage by 1.06%.
The diff coverage is 51.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   23.25%   24.32%   +1.06%     
==========================================
  Files          44       44              
  Lines        5486     5553      +67     
  Branches      805      836      +31     
==========================================
+ Hits         1276     1351      +75     
+ Misses       3688     3643      -45     
- Partials      522      559      +37
Impacted Files Coverage Δ
rust-code-analysis-cli/src/web/server.rs 58.91% <ø> (ø)
src/checker.rs 36.36% <ø> (ø)
src/output/dump_metrics.rs 32.89% <28.57%> (+<0.01%) ⬆️
src/metrics/nom.rs 58.22% <37.50%> (+6.91%) ⬆️
src/spaces.rs 61.84% <50.00%> (ø)
src/metrics/nargs.rs 54.16% <54.16%> (ø)
src/languages/language_javascript.rs 0.00% <0.00%> (ø)
src/metrics/halstead.rs 48.38% <0.00%> (+3.22%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6afee...7e8a531. Read the comment docs.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Dec 15, 2020

Depends on #373

@Luni-4 Luni-4 force-pushed the lambda-args branch 2 times, most recently from 8d2ab31 to 31993b8 Compare September 16, 2021 17:08
marco-c
marco-c reviewed Sep 16, 2021
View reviewed changes
src/metrics/nargs.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #352 (be5b6ba) into master (26c20bb) will increase coverage by 1.08%.
The diff coverage is 74.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   52.91%   53.99%   +1.08%     
==========================================
  Files          45       45              
  Lines        3572     3728     +156     
  Branches      844      871      +27     
==========================================
+ Hits         1890     2013     +123     
- Misses       1121     1127       +6     
- Partials      561      588      +27
Impacted Files Coverage Δ
rust-code-analysis-web/src/web/server.rs 60.64% <ø> (ø)
src/checker.rs 66.66% <ø> (ø)
src/output/dump_metrics.rs 33.76% <28.57%> (-0.01%) ⬇️
src/metrics/nargs.rs 75.70% <75.70%> (ø)
src/spaces.rs 64.67% <80.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c20bb...be5b6ba. Read the comment docs.

@Luni-4 Luni-4 requested a review from marco-c September 16, 2021 17:46
marco-c
marco-c reviewed Sep 16, 2021
View reviewed changes
src/metrics/nargs.rs Outdated Show resolved Hide resolved
marco-c
marco-c previously approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Luni-4 Luni-4 requested a review from marco-c September 16, 2021 19:27
@marco-c marco-c merged commit d5e1b3a into mozilla:master Sep 16, 2021
@Luni-4 Luni-4 deleted the lambda-args branch September 16, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider closures arguments for Nargs metric
4 participants
@Luni-4 @codecov-io @codecov-commenter @marco-c