Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests in a better way #353

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Nov 13, 2020

  • Remove useless \n
  • Split metrics unit tests for each language
  • Use more explicative names

@Luni-4 Luni-4 requested a review from marco-c November 13, 2020 21:00
marco-c
marco-c previously approved these changes Nov 16, 2020
@codecov-io
Copy link

Codecov Report

Merging #353 (6433c2e) into master (d893d07) will decrease coverage by 0.19%.
The diff coverage is 98.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   22.35%   22.16%   -0.20%     
==========================================
  Files          46       46              
  Lines        5722     5758      +36     
  Branches      813      813              
==========================================
- Hits         1279     1276       -3     
- Misses       3913     3960      +47     
+ Partials      530      522       -8     
Impacted Files Coverage Δ
src/metrics/cognitive.rs 59.00% <97.95%> (+7.41%) ⬆️
src/metrics/cyclomatic.rs 53.08% <100.00%> (-3.88%) ⬇️
src/metrics/exit.rs 55.88% <100.00%> (-2.95%) ⬇️
src/metrics/halstead.rs 45.16% <100.00%> (-3.23%) ⬇️
src/metrics/loc.rs 53.96% <100.00%> (-4.77%) ⬇️
src/metrics/mi.rs 60.60% <100.00%> (ø)
src/metrics/nom.rs 51.31% <100.00%> (-5.27%) ⬇️
src/getter.rs 39.82% <0.00%> (-8.66%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d893d07...6433c2e. Read the comment docs.

@marco-c marco-c merged commit 7baeb8b into mozilla:master Nov 20, 2020
@Luni-4 Luni-4 deleted the test-names branch November 20, 2020 11:12
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
- Remove useless \n
- Split metrics unit tests for each language
- Use more explicative names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants