Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump missing cyclomatic and cognitive fields #354

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Nov 13, 2020

This PR adds the new Cognitive and Cyclomatic sum and average fields when those metrics are dumped

@Luni-4 Luni-4 requested a review from marco-c November 13, 2020 21:46
@codecov-io
Copy link

Codecov Report

Merging #354 (9229d20) into master (03f1c9f) will increase coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   20.52%   20.55%   +0.02%     
==========================================
  Files          48       48              
  Lines        6236     6238       +2     
  Branches      815      815              
==========================================
+ Hits         1280     1282       +2     
  Misses       4426     4426              
  Partials      530      530              
Impacted Files Coverage Δ
src/output/dump_metrics.rs 33.77% <40.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f1c9f...9229d20. Read the comment docs.

@Luni-4 Luni-4 added the enhancement New feature or request label Nov 16, 2020
@marco-c marco-c merged commit fd55a85 into mozilla:master Dec 24, 2020
@Luni-4 Luni-4 deleted the dump-metrics branch December 24, 2020 11:12
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants