Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Go language #362

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Remove Go language #362

merged 1 commit into from
Nov 20, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Nov 16, 2020

Go language wasn't used for any kind of metric, so it is better to remove it

@Luni-4 Luni-4 requested a review from marco-c November 16, 2020 18:02
@Luni-4 Luni-4 changed the title Remove go Remove Go language Nov 16, 2020
marco-c
marco-c previously approved these changes Nov 20, 2020
@marco-c
Copy link
Collaborator

marco-c commented Nov 20, 2020

Can you rebase?

@codecov-io
Copy link

Codecov Report

Merging #362 (7acc3f1) into master (cb37ad9) will increase coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   22.58%   23.46%   +0.88%     
==========================================
  Files          45       44       -1     
  Lines        5663     5450     -213     
  Branches      808      805       -3     
==========================================
  Hits         1279     1279              
+ Misses       3854     3641     -213     
  Partials      530      530              
Impacted Files Coverage Δ
src/alterator.rs 35.71% <ø> (+3.24%) ⬆️
src/checker.rs 36.36% <ø> (ø)
src/getter.rs 48.48% <ø> (ø)
src/langs.rs 90.00% <ø> (ø)
src/metrics/cognitive.rs 51.59% <ø> (ø)
src/metrics/cyclomatic.rs 56.96% <ø> (ø)
src/metrics/exit.rs 58.82% <ø> (ø)
src/metrics/fn_args.rs 64.40% <ø> (ø)
src/metrics/halstead.rs 48.38% <ø> (ø)
src/metrics/loc.rs 58.73% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb37ad9...7acc3f1. Read the comment docs.

@marco-c marco-c merged commit 244a810 into mozilla:master Nov 20, 2020
@Luni-4 Luni-4 deleted the remove-go branch November 20, 2020 10:53
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants